Thread (1 message) 1 message, 1 author, 2011-05-04

Re: [PATCH v4 2/5] can: add rtnetlink support

From: Kurt Van Dijck <hidden>
Date: 2011-05-04 04:20:47

Besides some minor adaptions to support the SVN i left out some infrastructure
changes you made in patch 2/5 to constify this ...
quoted
-static struct can_proto *proto_tab[CAN_NPROTO] __read_mostly;
+static const struct can_proto *proto_tab[CAN_NPROTO] __read_mostly;
and this ...
quoted
-static struct can_proto *can_try_module_get(int protocol)
+static const struct can_proto *can_try_module_get(int protocol)
(..)
quoted
+static inline void can_put_proto(const struct can_proto *cp)
+{
+	module_put(cp->prot->owner);
+}
These infrastructure changes did not really belong to the rtnetlink support.
I see. I see I've made a mistake in the patch set here.
I'll go for a seperate 'make it const' patch.

Thanks,
Kurt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help