Hi,

Stanislaw, as Ben mentions, it's calling phy_ethtool_sset() which is
certainly meant to be an ETHTOOL_SSET op (from its name and comments)
even though its current implementation doesn't actually care for the
value of the cmd field.

Regards,

--
David Decotigny



On Thu, Apr 28, 2011 at 12:34 AM, Stanislaw Gruszka [off-list ref] wrote:

On Wed, Apr 27, 2011 at 09:32:38PM -0700, David Decotigny wrote:

quoted

--- a/drivers/net/stmmac/stmmac_ethtool.c
+++ b/drivers/net/stmmac/stmmac_ethtool.c

@@ -237,13 +237,12 @@ stmmac_set_pauseparam(struct net_device *netdev,

      if (phy->autoneg) {
              if (netif_running(netdev)) {
-                     struct ethtool_cmd cmd;
+                     struct ethtool_cmd cmd = { .cmd = ETHTOOL_SSET };
                      /* auto-negotiation automatically restarted */
-                     cmd.cmd = ETHTOOL_NWAY_RST;

Why did you change ETHTOOL_NWAY_RST to ETHTOOL_SSET ?