Re: linux-next: ibmveth runtime errors
From: Stephen Rothwell <hidden>
Date: 2011-04-28 02:11:32
Also in:
linux-next, linuxppc-dev, lkml
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Hi Michał, On Wed, 27 Apr 2011 12:36:22 +0200 Michał Mirosław [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Please test the following patch. It's just a blind guess, as this error is not descriptive. Best Regards, Michał Mirosław --- net: ibmveth: force reconfiguring checksum settings on startup Commit b9367bf3ee6d ("net: ibmveth: convert to hw_features") accidentally removed call to ibmveth_set_csum_offload() in ibmveth_probe(). Put the call back where it was, but with additional error checking provided by ibmveth_set_features(). Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Reported-by: Stephen Rothwell <redacted> --- drivers/net/ibmveth.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index 4855f1f..0d1fea2 100644 --- a/drivers/net/ibmveth.c +++ b/drivers/net/ibmveth.c@@ -1397,6 +1397,8 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, netdev_dbg(netdev, "registering netdev...\n"); + ibmveth_set_features(dev, dev->features); + rc = register_netdev(netdev); if (rc) {
This worked after I changed both "dev"s to "netdev". And the boot
succedded. I will apply this patchg to linux-next today and hopefully
Dave can apply it to the net tree. I have added a copy fo the patch I
used below.
From: =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Date: Thu, 28 Apr 2011 11:59:15 +1000
Subject: [PATCH] net: ibmveth: force reconfiguring checksum settings on
startup
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Commit b9367bf3ee6d ("net: ibmveth: convert to hw_features") accidentally
removed call to ibmveth_set_csum_offload() in ibmveth_probe(). Put the
call back where it was, but with additional error checking provided
by ibmveth_set_features().
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Reported-by: Stephen Rothwell <redacted>
[sfr: dev -> netdev]
Signed-off-by: Stephen Rothwell <redacted>
---
drivers/net/ibmveth.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index 4855f1f..be3fe71 100644
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c@@ -1397,6 +1397,8 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, netdev_dbg(netdev, "registering netdev...\n"); + ibmveth_set_features(netdev, netdev->features); + rc = register_netdev(netdev); if (rc) {
--
1.7.4.4
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/