Re: [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap
From: "Michael Chan" <mchan@broadcom.com>
Date: 2011-04-21 17:23:48
Also in:
lkml
On Wed, 2011-04-20 at 23:39 -0700, Joe Perches wrote:
quoted hunk ↗ jump to hunk
@@ -4622,7 +4611,7 @@ static void tg3_tx_recover(struct tg3 *tp) "and include system chipset information.\n"); spin_lock(&tp->lock); - tp->tg3_flags |= TG3_FLAG_TX_RECOVERY_PENDING; + tg3_flag_set(tp, TX_RECOVERY_PENDING); spin_unlock(&tp->lock); }
By using set_bit() now, we can eliminate the spin_lock() here. This flag is checked much later when tg3_reset_task() is scheduled to run in workqueue, so no memory barrier is needed either. Thanks.