Re: [PATCH] ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets

Le mercredi 06 avril 2011 à 11:27 -0700, David Miller a écrit :

From: Eric Dumazet <redacted>
Date: Wed, 06 Apr 2011 20:23:08 +0200

quoted

Le mercredi 06 avril 2011 à 11:17 -0700, David Miller a écrit :

quoted

From: Eric Dumazet <redacted>
Date: Wed, 06 Apr 2011 20:07:33 +0200

quoted

This is why we used on ipv4 :

if (inet_sk(sk)->inet_daddr)
	sock_rps_save_rxhash(sk, skb->rxhash);


Only arm RFS on UDP if socket is bound to a given remote peer.

Agreed, Neil please make this change to your ipv6 code.

BTW, do you guys know if NFS is using RFS right now (if TCP transport is
used) ?

It ought to be.  Are you specifically concerned that it might be
missing the rxhash setting calls because of the APIs it uses to
do socket I/O?

The SunRPC layer is a major user of tcp_read_sock(), for example.

But the packet processing will be done via the normal means,
therefore we'll hit tcp_v4_do_rcv() and therefore save the
rxhash.

Hmm, are multiple tcp sessions used between NFS client and server (One
per cpu on client ?)