Thread (9 messages) 9 messages, 5 authors, 2011-03-01

Re: [Open-FCoE] [PATCH] fcoe: correct checking for bonding

From: Vasu Dev <hidden>
Date: 2011-03-01 18:09:47
Also in: linux-scsi

On Tue, 2011-03-01 at 10:01 -0800, Vasu Dev wrote:
On Tue, 2011-03-01 at 09:49 -0800, Joe Eykholt wrote:
quoted
Otherwise I'd add some parens or I might code this as:

        if ((netdev->priv_flags & (IFF_BONDING | IFF_MASTER)) ==
            (IFF_BONDING | IFF_MASTER))
or also skip == in code as:-

if (netdev->priv_flags & (IFF_BONDING | IFF_MASTER)) 

Would least save few chars in source code.
Never mind, you wanted to check both bits set instead checking only one
of them, my mistake, anycase these are in different fields as another
most recent response mentioned.

	Vasu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help