Re: [PATCH] pl25a1_support
From: David Miller <davem@davemloft.net>
Date: 2011-03-30 09:40:43
Also in:
lkml
From: Simon Wood <redacted> Date: Tue, 29 Mar 2011 21:44:27 -0600
quoted hunk ↗ jump to hunk
@@ -89,13 +97,17 @@ static int pl_reset(struct usbnet *dev) /* some units seem to need this reset, others reject it utterly. * FIXME be more like "naplink" or windows drivers. */ - (void) pl_set_QuickLink_features(dev, + int status; + + status = pl_set_QuickLink_features(dev, PL_S_EN|PL_RESET_OUT|PL_RESET_IN|PL_PEER_E);
Poor indentation here in the status assignment, there should be only a single TAB character before "status =". Also, declare the local variable at the beginning of the function, before the function, not after it. And get rid of that tab between "int" and "status, like this: int status; /* some units seem to need this reset, others reject it utterly. * FIXME be more like "naplink" or windows drivers. */