Thread (4 messages) flat view 4 messages, 3 authors, 2011-03-18

Re: [PATCH] headers: use __aligned_xx types for userspace

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2011-03-18 23:28:34
Also in: lkml

On Fri, 18 Mar 2011 14:50:37 -0400
Mike Frysinger [off-list ref] wrote:
Now that we finally have __aligned_xx exported to userspace, convert
the headers that get exported over to the proper type.
Sob.  Please don't assume that because you're on top of an issue, all
the rest of us are.

A bit of git-log grovelling turns up

: commit 79b5dc0c64d88cda3da23b2e22a5cec0964372ac
: Author: Eric Paris [off-list ref]
: Date:   Fri Oct 15 14:34:14 2010 -0700                                          
:     types.h: define __aligned_u64 and expose to userspace
:     
:     We currently have a kernel internal type called aligned_u64 which aligns
:     __u64's on 8 bytes boundaries even on systems which would normally align
:     them on 4 byte boundaries.  This patch creates a new type __aligned_u64
:     which does the same thing but which is exposed to userspace rather than
:     being kernel internal.                                                    

but that really doesn't tell us why it was merged either.  Perhaps that
came out in the followup discussion and I failed to fix the changelog.


Still, it doesn't hurt to educate people.  Please explain why we are
making this change?
 include/linux/if_ppp.h                    |   16 ++++++++--------
 include/linux/netfilter/nfnetlink_log.h   |    4 ++--
 include/linux/netfilter/nfnetlink_queue.h |    4 ++--
 include/linux/netfilter/xt_connbytes.h    |    4 ++--
 include/linux/netfilter/xt_quota.h        |    2 +-
 5 files changed, 15 insertions(+), 15 deletions(-)
davem stuff :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help