Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

[PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop · Jason Wang <jasowang@redhat.com> · 2011-01-17
[PATCH 2/3] vhost-net: Unify the code of mergeable and big buffer handling · Jason Wang <jasowang@redhat.com> · 2011-01-17
Re: [PATCH 2/3] vhost-net: Unify the code of mergeable and big buffer handling · "Michael S. Tsirkin" <mst@redhat.com> · 2011-01-17
Re: [PATCH 2/3] vhost-net: Unify the code of mergeable and big buffer handling · Jason Wang <jasowang@redhat.com> · 2011-01-18
Re: [PATCH 2/3] vhost-net: Unify the code of mergeable and big buffer handling · "Michael S. Tsirkin" <mst@redhat.com> · 2011-01-18
Re: [PATCH 2/3] vhost-net: Unify the code of mergeable and big buffer handling · Jason Wang <jasowang@redhat.com> · 2011-01-18
[PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() · Jason Wang <jasowang@redhat.com> · 2011-01-17
Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() · Eric Dumazet <hidden> · 2011-01-17
Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() · "Michael S. Tsirkin" <mst@redhat.com> · 2011-01-17
Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() · "Michael S. Tsirkin" <mst@redhat.com> · 2011-03-13
Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() · Eric Dumazet <hidden> · 2011-03-13
Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() · "Michael S. Tsirkin" <mst@redhat.com> · 2011-03-13
Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() · Eric Dumazet <hidden> · 2011-03-13
Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() · "Michael S. Tsirkin" <mst@redhat.com> · 2011-03-13
Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() · Eric Dumazet <hidden> · 2011-03-13
Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() · "Michael S. Tsirkin" <mst@redhat.com> · 2011-03-13
Re: [PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop · "Michael S. Tsirkin" <mst@redhat.com> · 2011-01-17
Re: [PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop · Jason Wang <jasowang@redhat.com> · 2011-01-18
Re: [PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop · "Michael S. Tsirkin" <mst@redhat.com> · 2011-01-18
Re: [PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop · Jason Wang <jasowang@redhat.com> · 2011-01-18

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2011-03-13 16:44:47
Also in: kvm, lkml, virtualization

On Sun, Mar 13, 2011 at 05:32:07PM +0100, Eric Dumazet wrote:

Le dimanche 13 mars 2011 à 18:19 +0200, Michael S. Tsirkin a écrit :

quoted

Other side is in drivers/net/tun.c and net/packet/af_packet.c
At least wrt tun it seems clear socket is not locked.

Yes (assuming you refer to tun_net_xmit())

quoted

Besides queue, dequeue seems to be done without socket locked.

It seems this code (assuming you speak of drivers/vhost/net.c ?) has
some races indeed.

Hmm. Any more besides the one fixed here?

-- 
MST

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help