Re: [PATCH] skge: convert to hw_features
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2011-03-31 20:48:08
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2011-03-31 20:48:08
On Thu, Mar 31, 2011 at 08:41:02AM -0700, Stephen Hemminger wrote:
On Thu, 31 Mar 2011 13:01:35 +0200 (CEST) Michał Mirosław [off-list ref] wrote:quoted
quoted
From the code it looks like the hardware might support full HW_CSUM notjust IP_CSUM. This needs testing and so is not changed here. Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>I don't think this will work right. The old code did not allow setting tx/rx csum on the older GENESIS chip,
If you look at the changes near the end of patche, the hw_features are set (and so features are made changeable) only when hw->chip_id != CHIP_ID_GENESIS. Best Regards, Michał Mirosław