Re: [PATCH] smsc911x: Use pr_fmt, netdev_<level>, and netif_<level>

Re: [PATCH] smsc911x: Use pr_fmt, netdev_ , and netif_

David Miller · 2011-03-30T21:43:07-0700

From: Joe Perches Date: Fri, 25 Mar 2011 17:21:22 -0700 > Use the more common/verbose logging styles. > > Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > Remove smsc911x prefixes from format strings. > Rename SMSC_WARNING to SMSC_WARN. > Remove DPRINTK macro. > Use netif_ in SMSC_ macros. > Convert NETIF_MSG_ uses to lower case. > Add no_printk verification in non-debug uses. > Add pdata to SMSC_ uses to avoid hidden variable uses. > Convert printks to netdev_ as appropriate. > > Signed-off-by: Joe Perches Applied.

From: David Miller <davem@davemloft.net>
Date: 2011-03-31 04:43:45

From: Joe Perches <joe@perches.com>
Date: Fri, 25 Mar 2011 17:21:22 -0700

Use the more common/verbose logging styles.

Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Remove smsc911x prefixes from format strings.
Rename SMSC_WARNING to SMSC_WARN.
Remove DPRINTK macro.
Use netif_<level> in SMSC_<level> macros.
Convert NETIF_MSG_<foo> uses to lower case.
Add no_printk verification in non-debug uses.
Add pdata to SMSC_<level> uses to avoid hidden variable uses.
Convert printks to netdev_<level> as appropriate.

Signed-off-by: Joe Perches <joe@perches.com>

Applied.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help