Re: [PATCH] netxen: fix LRO disable warning

On Mon, Mar 28, 2011 at 12:33:43AM -0500, Amit Salecha wrote:

quoted

quoted

quoted

quoted

netxen_nic_set_flags() rejects data if other flag than

ETH_FLAG_LRO

quoted

quoted

is set.

quoted

Driver also supports NETIF_F_HW_VLAN_TX.
Now compare data with ethtool_op_get_flags(), to get all supported

features.

quoted

Reported-by: Jesper Dangaard Brouer <redacted>
Signed-off-by: Rajesh Borundia <redacted>
Signed-off-by: Amit Kumar Salecha <redacted>
---

Hmm, it would be really nice you provide more information for stable
teams.

If I am not mistaken, bug was introduced in 2.6.36 ?

No, It was introduced in 2.6.37, when ETH_FLAG_TXVLAN and

ETH_FLAG_RXVLAN introduced.

quoted

Yes it should also make into 2.6.37.4 stable kernel.

Applied, but 2.6.37.x maintainence has ceased so there is no point
worrying about this patch for that stable branch any longer.

2.6.38 needs that fix as well ...

I thought you will apply patch from Stanislaw Gruszka (net: fix ethtool->set_flags not intended -EINVAL return value), which is more generic and takes care of all drivers.

David, you are not cc in that patch. I will forward you, in case you miss it.

Patch is here:
http://patchwork.ozlabs.org/patch/88060/

I could also repost rebased patch if needed.

Stanislaw