Re: [PATCH] Fix IP timestamp option (IPOPT_TS_PRESPEC) handling in ip_options_echo()

From: Jan Luebbe <redacted>
Date: Thu, 24 Mar 2011 18:44:22 +0100

-					if (soffset + 8 <= optlen) {
+					if (soffset + 7 <= optlen) {

I don't see how you can legally reduce this check from 8 to 7 bytes.

+						if (inet_addr_type(dev_net(skb_dst(skb)->dev), addr) != RTN_UNICAST) {
 							dopt->ts_needtime = 1;
 							soffset += 8;
 						}

Yet keep this code which advances soffset by 8.