Re: RFC: [PATCH] can: c_can: disable one shot mode until driver is fixed
From: Kurt Van Dijck <hidden>
Date: 2011-03-24 10:28:52
Subsystem:
can network drivers, the rest · Maintainers:
Marc Kleine-Budde, Vincent Mailhol, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2011-03-24 · Re: RFC: [PATCH] can: c_can: disable one shot mode until driver is fixed · Kurt Van Dijck <hidden>
- 2011-03-24 · Re: RFC: [PATCH] can: c_can: disable one shot mode until driver is fixed · Marc Kleine-Budde <hidden>
- 2011-03-24 · RFC: [PATCH] can: c_can: disable one shot mode until driver is fixed · Marc Kleine-Budde <hidden>
On Thu, Mar 24, 2011 at 11:12:29AM +0100, Marc Kleine-Budde wrote:
This patch disables the one shot mode, until the driver has been fixed and tested to support it.
isn't this part necessary now (temporarily) to avoid dead code?
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
index 1405078..2c3d090 100644
--- a/drivers/net/can/c_can/c_can.c
+++ b/drivers/net/can/c_can/c_can.c@@ -588,14 +588,9 @@ static void c_can_chip_config(struct net_device *dev) { struct c_can_priv *priv = netdev_priv(dev); - if (priv->can.ctrlmode & CAN_CTRLMODE_ONE_SHOT) - /* disable automatic retransmission */ - priv->write_reg(priv, &priv->regs->control, - CONTROL_DISABLE_AR); - else - /* enable automatic retransmission */ - priv->write_reg(priv, &priv->regs->control, - CONTROL_ENABLE_AR); + /* enable automatic retransmission */ + priv->write_reg(priv, &priv->regs->control, + CONTROL_ENABLE_AR); if (priv->can.ctrlmode & (CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK)) {