Re: [RFC] myri10ge: small rx_done refactoring

On 03/23/11 08:52, Stanislaw Gruszka wrote:

on my i686 system, what should also make myri10ge_clean_rx_done()
being faster.

I tested this on my very old, very weak dual-core athlon64 systems.
These machines can barely achieve 10Gb/s using a 1500b MTU with LRO.
Running 35 60 second netperf tests into the machines with the stock
driver, and again with this patch applied, I see a tiny bandwidth
increase (1.4Mb/s on average) which is statistically significant
( p <  0.001). There is no statistically significant CPU load
reduction.

+	if (len<= mgp->small_bytes) {
+		rx =&ss->rx_small;
+		bytes = mgp->small_bytes;
+	} else {
+		rx =&ss->rx_big,

Small nit:  the "," above should be a ";"

Between the small bandwidth increase, and the code size reduction,
I'm very appreciative of this patch.

Thank you,

Drew