Thread (3 messages) flat view 3 messages, 3 authors, 2011-03-19

Re: [patch] ftmac100: use resource_size()

From: Po-Yu Chuang <hidden>
Date: 2011-03-19 05:06:14
Also in: kernel-janitors

Hi Dan,

On Sat, Mar 19, 2011 at 12:39 PM, Dan Carpenter [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The calculation is off-by-one.  It should be "end - start + 1".  This
patch fixes it to use resource_size() instead.  Oddly, the code already
uses resource size correctly a couple lines earlier when it calls
request_mem_region() for this memory.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/ftmac100.c b/drivers/net/ftmac100.c
index 1d6f4b8..a316619 100644
--- a/drivers/net/ftmac100.c
+++ b/drivers/net/ftmac100.c
@@ -1102,7 +1102,7 @@ static int ftmac100_probe(struct platform_device *pdev)
               goto err_req_mem;
       }

-       priv->base = ioremap(res->start, res->end - res->start);
+       priv->base = ioremap(res->start, resource_size(res));
       if (!priv->base) {
               dev_err(&pdev->dev, "Failed to ioremap ethernet registers\n");
               err = -EIO;
Ah, I incautiously missed that line when code review.

Thanks,
Po-Yu Chuang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help