Re: [PATCH 02/17] cgroup, rcu: convert call_rcu(free_cgroup_rcu) to kfree_rcu()
From: Paul Menage <hidden>
Date: 2011-03-15 20:04:00
Also in:
linux-nfs
2011/3/15 Lai Jiangshan [off-list ref]:
The rcu callback free_cgroup_rcu() just calls a kfree(), so we use kfree_rcu() instead of the call_rcu(free_cgroup_rcu). Signed-off-by: Lai Jiangshan <redacted>
Acked-by: Paul Menage <redacted>
quoted hunk
--- kernel/cgroup.c | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-)diff --git a/kernel/cgroup.c b/kernel/cgroup.c index ad485d4..5c83c91 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c@@ -806,13 +806,6 @@ static int cgroup_call_pre_destroy(struct cgroup *cgrp)return ret; } -static void free_cgroup_rcu(struct rcu_head *obj) -{ - struct cgroup *cgrp = container_of(obj, struct cgroup, rcu_head); - - kfree(cgrp); -} - static void cgroup_diput(struct dentry *dentry, struct inode *inode) { /* is dentry a directory ? if so, kfree() associated cgroup */@@ -850,7 +843,7 @@ static void cgroup_diput(struct dentry *dentry, struct inode *inode)*/ BUG_ON(!list_empty(&cgrp->pidlists)); - call_rcu(&cgrp->rcu_head, free_cgroup_rcu); + kfree_rcu(cgrp, rcu_head); } iput(inode); } -- 1.7.4