Re: ECN + pfifo_fast borked? (Was Re: [Bloat] shaper team forming up)

Le mardi 15 mars 2011 à 20:37 +0200, Jonathan Morton a écrit :

On 15 Mar, 2011, at 8:28 pm, Eric Dumazet wrote:

quoted

quoted

quoted

band 0 : high priority packets (like now)
band 1 : (old band 1, ECN capable flows)
band 2 : (old band 1, no ECN flows)
band 3 : low priority packets (old band 2)

This seems good to me.  It would provide a concrete (if minor) enticement to turn ECN on.

Here is a patch to implement that, on top of net-next-2.6 git tree

Does this take both ECN bits into account?  The ECT(0), ECT(1) and ECE codepoints all need to be recognised equally.

This is done in a different layer, as already explained.

Current linux code ignores low order bit when doing TOS -> skb->priority
mapping.