RE: [net-next-2.6 04/14] net: add ndo_fcoe_ddp_target() to support FCoE DDP in target mode

On Mon, 2011-03-07 at 18:24 -0800, Jeff Kirsher wrote:

quoted

From: Yi Zou <redacted>

The Fiber Channel over Ethernet (FCoE) Direct Data Placement (DDP) can

also be

quoted

used for FCoE target, where the DDP used for read I/O on an initiator

can be

quoted

used on an FCoE target to speed up the write I/O to the target from the

initiator.

quoted

The added ndo_fcoe_ddp_target() works in the similar way as the

existing

quoted

ndo_fcoe_ddp_setup() to allow the underlying hardware set up the DDP

context

quoted

accordingly when it gets called from the FCoE target implementation on

top

quoted

the existing Open-FCoE fcoe/libfc protocol stack so without losing the

ability

quoted

to provide DDP for read I/O as an initiator, it can also provide DDP

offload

quoted

to the write I/O coming from the initiator as a target.

Signed-off-by: Yi Zou <redacted>
Signed-off-by: Kiran Patil <redacted>
Tested-by: Kavindya Deegala <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
 include/linux/netdevice.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 71563e7..6bd5d46 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h

@@ -871,6 +871,10 @@ struct net_device_ops {
 						      unsigned int sgc);
 	int			(*ndo_fcoe_ddp_done)(struct net_device *dev,
 						     u16 xid);
+	int			(*ndo_fcoe_ddp_target)(struct net_device *dev,
+						       u16 xid,
+						       struct scatterlist *sgl,
+						       unsigned int sgc);

This should be described in the comment heading net_device_ops.
(Really, all the existing FCoE operations ought to have been described
as well.)

Ben.

Yes, you are right, it should be. Will it be ok if I send a separate 
patch as follow-up to properly add all comments?

yi

quoted

 #define NETDEV_FCOE_WWNN 0
 #define NETDEV_FCOE_WWPN 1
 	int			(*ndo_fcoe_get_wwn)(struct net_device *dev,

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.