Thread (2 messages) flat view 2 messages, 2 authors, 2011-03-23
STALE5659d REVIEWED: 1 (0M)

1 review trailer.

[PATCH] ethtool: remove mask for Auto in advertise section

From: Jeff Kirsher <hidden>
Date: 2011-03-05 07:27:05
Subsystem: the rest · Maintainer: Linus Torvalds

From: Emil Tantilov <redacted>

The mask for Auto in the advertise section is incorrect for any interface
that supports speeds > 1000Mbps. Since the description already states that
the mask can be a combination of the supported values it's probably better
to just remove it. 'Auto' was misleading anyway.

Signed-off-by: Emil Tantilov <redacted>
Tested-by: Stephen Ko <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
 ethtool.8.in |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/ethtool.8.in b/ethtool.8.in
index 0ee91a0..d7bcc51 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -516,8 +516,6 @@ a hexadecimal value using one or a combination of the following values:
 .BR "0x8000" "   2500 Full" "(not supported by IEEE standards)"
 .TP 3
 .BR "0x1000" "   10000 Full"
-.TP 3
-.BR "0x03F" "    Auto"
 .PD
 .RE
 .TP
-- 
1.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help