Re: [PATCH v2 09/13] can: pruss CAN driver.

On 02/18/2011 09:15 AM, Subhasish Ghosh wrote:

quoted

On 02/18/2011 08:07 AM, Subhasish Ghosh wrote:

quoted

--------------------------------------------------
From: "Kurt Van Dijck" <kurt.van.dijck-/BeEPy95v10@public.gmane.org>

...

quoted

quoted

quoted

+ /* register interrupt handler */
+ err = request_irq(priv->trx_irq, &omapl_rx_can_intr, IRQF_SHARED,
+   "pru_can_irq", ndev);

you're doing a lot of work _in_ the irq handler. Maybe threaded irq?

SG -Ok, will do

No, please use NAPI instead.

We are using h/w filters, so the number of interrupts coming into the
processor are not hogging it.
I feel that we may not require an interrupt mitigation.

As davem stated the other day, all new drivers should use NAPI.

regards, Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |