Thread (7 messages) 7 messages, 4 authors, 2011-02-07

Re: x25: possible skb leak on bad facilities

From: David Miller <davem@davemloft.net>
Date: 2011-02-07 04:27:50
Also in: lkml

From: Andrew Hendry <redacted>
Date: Tue, 1 Feb 2011 22:55:13 +1100
There are two callers, when I was crashing it I don't remember it
using the backlog path.
x25_process_rx_frame is called from both x25_backlog_rcv and also
x25_receive_data (via x25_lapb_receive_frame)

But reviewing that second path now it looks like it will also leak, -1
would make it skip the kfree_skb there as well.
So patch looks good to me, when I have some time I'll run it through
the environment I had setup originally to confirm.
Andrew, have you had a chance to do this yet?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help