On Wed, Feb 23, 2011 at 11:37:49PM +0000, Ben Hutchings wrote:

On Wed, 2011-02-23 at 15:13 -0800, David Miller wrote:

quoted

From: Phil Oester <redacted>
Date: Wed, 23 Feb 2011 15:08:44 -0800

quoted

On Wed, Feb 23, 2011 at 02:42:49PM -0500, Andy Gospodarek wrote:

quoted

+ * destination queue.  Using a helper function skips the a call to

s/the a/a/ or s/the a/the/

quoted

+     while (txq >= dev->real_num_tx_queues) {
+             /* let the user know if we do not have enough tx queues */
+             if (net_ratelimit())
+                     pr_warning("%s selects invalid tx queue %d.  Consider"
+                                " setting module option tx_queues > %d.",
+                                dev->name, txq, dev->real_num_tx_queues);
+             txq -= dev->real_num_tx_queues;
+     }

Think this would be better as a WARN_ONCE, as otherwise syslog will still
get flooded with this - even when ratelimited.  See get_rps_cpu in 
net/core/dev.c as an example.o

Agreed.

This shouldn't WARN at all.  It is perfectly valid (though non-optimal)
to have different numbers of queues on two different multiqueue devices.

Agreed.  Plus WARN seemed way to 'loud' for something like this.