Re: [PATCH] cxgb{3,4}: streamline Kconfig options
From: David Miller <davem@davemloft.net>
Date: 2011-02-23 20:27:09
Also in:
linux-kbuild
From: "Jan Beulich" <redacted> Date: Wed, 23 Feb 2011 09:46:10 +0000
quoted
quoted
quoted
On 22.02.11 at 19:14, David Miller [off-list ref] wrote:From: "Jan Beulich" <redacted> Date: Thu, 17 Feb 2011 13:29:30 +0000quoted
The CHELSIO_T{3,4}_DEPENDS options are really awkward, and can be easily dropped if the reverse dependencies of SCSI_CXGB{3,4}_ISCSI on the former get converted to normal (forward) ones referring to CHELSIO_T{3,4}. Signed-off-by: Jan Beulich <redacted>I think the goal of these strange rules is not to be complicated on purpose, but rather to cause the iSCSI drivers to appear without the user having to know that he needs to enable the networking driver in order for that to happen.While I realize that this might have been the reason, it's completely contrary to how everyone else writes dependencies, and hence I think these should be removed.
If you knew you were changing the behavior of the config option in this way, you sure didn't think it was worth mentioning in your commit message. I definitely would never expect to have to enable a scsi option to get some network driver visible to enable in the config, and therefore I could see the opposite being insanely frustrating too. You can't ignore these issues and just say "that's not the normal way so I'm going to change it anyways."