Re: Off-by-one error in net/8021q/vlan.c
From: richard -rw- weinberger <hidden>
Date: 2011-02-16 12:51:35
On Wed, Feb 16, 2011 at 11:58 AM, Phil Karn [off-list ref] wrote:
The range check on vlan_id in register_vlan_device is off by one, and it prevents the creation of a vlan interface for vlan ID 4095. (OSX allows this, I checked.)
Then OSX should fix their code. 4095 is reserved. //richard
quoted hunk ↗ jump to hunk
Here's the trivial patch:--- linux-2.6.37/net/8021q/vlan.c~ 2011-01-04 16:50:19.000000000 -0800 +++ linux-2.6.37/net/8021q/vlan.c 2011-02-16 02:43:13.988812958 -0800@@ -239,7 +239,7 @@char name[IFNAMSIZ]; int err; - if (vlan_id >= VLAN_VID_MASK) + if (vlan_id > VLAN_VID_MASK) return -ERANGE; err = vlan_check_real_dev(real_dev, vlan_id); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Thanks, //richard