Re: [PATCH net-26 1/5] cxgb4vf: Virtual Interfaces are always up ...
From: Casey Leedom <hidden>
Date: 2011-02-14 22:31:34
| From: Casey Leedom [off-list ref] | Date: Monday, February 14, 2011 11:13 am | | | No driver specific module parameters! Add something generic and common | | so other drivers can use it too. | | | | Otherwise every user has to learn a different way to control this | | attribute, depending upon the device type, which is rediculious. | | | | How many times do we have to tell driver authors this? | | Sorry. I wasn't aware of this rule. My bad. Is this writeen down | somewhere under Documentation? I'm not being snarky. I really would like | to know so I can read through the general ground rules and avoid making | more mistakes in the future. | | As for a generic mechanism, what's the preferred way of doing this? A | new ethtool flag? Sorry for being a doofus here, I'm happy to follow | whatever the accepted standard is. Thanks for your time and patience. Also, I assume then the the entire patch series is now rejected, right? And that I should resubmit the patch series without the unacceptable module parameter, right? I'm just trying to figure out what I need to do next. Thanks. Casey