RE: [PATCH net-next-2.6 v7 1/1] can: c_can: Added support for Bosch C_CAN controller

Hi David,

-----Original Message-----
From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org]
Sent: Monday, February 14, 2011 12:36 AM
To: mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Cc: Bhupesh SHARMA; netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Socketcan-
core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
Subject: Re: [PATCH net-next-2.6 v7 1/1] can: c_can: Added support for
Bosch C_CAN controller

From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Date: Sun, 13 Feb 2011 10:52:16 -0800 (PST)

quoted

From: Marc Kleine-Budde <redacted>
Date: Sat, 12 Feb 2011 18:18:37 +0100

quoted

On 02/11/2011 11:17 AM, Bhupesh Sharma wrote:

quoted

Bosch C_CAN controller is a full-CAN implementation which is

compliant

quoted

quoted

quoted

to CAN protocol version 2.0 part A and B. Bosch C_CAN user manual

can be

quoted

quoted

quoted

obtained from:
http://www.semiconductors.bosch.de/media/en/pdf/ipmodules_1/
c_can/users_manual_c_can.pdf

This patch adds the support for this controller.
The following are the design choices made while writing the

controller

quoted

quoted

quoted

driver:
1. Interface Register set IF1 has be used only in the current

design.

quoted

quoted

quoted

2. Out of the 32 Message objects available, 16 are kept aside for

RX

quoted

quoted

quoted

   purposes and the rest for TX purposes.
3. NAPI implementation is such that both the TX and RX paths

function

quoted

quoted

quoted

   in polling mode.

Signed-off-by: Bhupesh Sharma <redacted>

Good work!

Acked-by: Marc Kleine-Budde <redacted>

Applied.

Actually, I'm reverting because this causes build regressions:

ERROR: "clk_get_rate" [drivers/net/can/c_can/c_can_platform.ko]
undefined!
ERROR: "clk_get" [drivers/net/can/c_can/c_can_platform.ko] undefined!
ERROR: "clk_put" [drivers/net/can/c_can/c_can_platform.ko] undefined!

Oops.. I will send a v8 to correct this compilation issue a.s.a.p.

Regards,
Bhupesh