Thread (25 messages) flat view 25 messages, 2 authors, 2011-02-22
STALE5655d

[PATCH 05/14] net/fec: no need to memzero private data

From: Uwe Kleine-König <hidden>
Date: 2011-02-11 10:32:32
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

alloc_etherdev internally uses kzalloc, so the private data is already
zerod out.

Noticed-by: Lothar Waßmann [off-list ref]
Signed-off-by: Uwe Kleine-König <redacted>
---
 drivers/net/fec.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fec.c b/drivers/net/fec.c
index 8026a16..9a25e1e 100644
--- a/drivers/net/fec.c
+++ b/drivers/net/fec.c
@@ -1386,7 +1386,6 @@ fec_probe(struct platform_device *pdev)
 
 	/* setup board info structure */
 	fep = netdev_priv(ndev);
-	memset(fep, 0, sizeof(*fep));
 
 	ndev->base_addr = (unsigned long)ioremap(r->start, resource_size(r));
 	fep->pdev = pdev;
-- 
1.7.2.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help