Thread (9 messages) 9 messages, 2 authors, 2011-02-13

Re: [net-2.6 PATCH 1/3] net: dcb: match dcb_app protocol field with 802.1Qaz spec

From: John Fastabend <hidden>
Date: 2011-02-05 19:39:13

On 1/31/2011 8:41 PM, David Miller wrote:
From: John Fastabend <redacted>
Date: Mon, 31 Jan 2011 14:00:49 -0800
quoted
The dcb_app protocol field is a __u32 however the 802.1Qaz
specification defines it as a 16 bit field. This patch brings
the structure inline with the spec making it a __u16.

Signed-off-by: John Fastabend <redacted>
 ...
quoted
@@ -101,7 +101,7 @@ struct ieee_pfc {
  */
 struct dcb_app {
 	__u8	selector;
-	__u32	protocol;
+	__u16	protocol;
 	__u8	priority;
 };
 
If we're going to do this, please fix this wasteful structure
layout.  Put the "protocol" either first, or last, so that the
structure size is 4 bytes, rather than something like 8.
OK I will fix this. Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help