Re: [PATCH v2] x25: remove the BKL
From: Eric Dumazet <hidden>
Date: 2011-01-27 13:20:55
Also in:
lkml
Le jeudi 27 janvier 2011 à 13:38 +0100, Arnd Bergmann a écrit :
quoted hunk ↗ jump to hunk
diff --git a/net/x25/x25_out.c b/net/x25/x25_out.c index d00649f..f1a6ff1 100644 --- a/net/x25/x25_out.c +++ b/net/x25/x25_out.c@@ -68,8 +68,11 @@ int x25_output(struct sock *sk, struct sk_buff *skb) frontlen = skb_headroom(skb); while (skb->len > 0) { - if ((skbn = sock_alloc_send_skb(sk, frontlen + max_len, - noblock, &err)) == NULL){ + release_sock(sk); + skbn = sock_alloc_send_skb(sk, frontlen + max_len, + 1, &err); + lock_sock(sk); + if (!skbn) { if (err == -EWOULDBLOCK && noblock){ kfree_skb(skb); return sent;
This part looks strange : noblock variable became "const 1 : NOBLOCK" Why releasing socket if you dont block in sock_alloc_send_skb() ?