Re: [PATCH] Cleanup include/net/tcp.h include-files and coding-style

On Monday, January 10, 2011 wrote Alexey Dobriyan:

quoted

quoted

linux/percpu_counter.h (needed for percpu_counter_sum_positive)

Yes.

Currently code compiles fine, so necessary headers are in place,
so simply adding new headers doesn't help anything.

I totally agree with you.
However we need a consistent coding style.

Or we just include the minimum necessary headers (as originally proposed by 
me).
Or we include every header whose structs/functions are referenced.

In my opinion the current "mixed" state is not ok, because some includes are 
there because there *are* references (even if these includes could be omitted, 
e.g., linux/list.h).
Other includes (like linux/percpu_counter.h) are not there, because they are 
indirectly included by another header and thus the code compiles. Even if 
there are references.
And there are no rules/guidelines to identify the headers that should be 
included and those that should not.

Regards,
Christoph

--
Christoph Paasch
PhD Student

IP Networking Lab --- http://inl.info.ucl.ac.be
MultiPath TCP in the Linux Kernel --- http://inl.info.ucl.ac.be/mptcp
Université Catholique de Louvain

www.rollerbulls.be
--