Re: [PATCH] net: ixp4xx_eth: Return proper error for eth_init_one
flat view
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: 2011-01-05 17:43:51
Also in:
lkml
Axel Lin [off-list ref] writes:
Return PTR_ERR(port->phydev) instead of 1 if phy_connect failed. Signed-off-by: Axel Lin <redacted>
quoted hunk
--- a/drivers/net/arm/ixp4xx_eth.c +++ b/drivers/net/arm/ixp4xx_eth.c@@ -1229,8 +1229,10 @@ static int __devinit eth_init_one(struct platform_device *pdev) snprintf(phy_id, MII_BUS_ID_SIZE + 3, PHY_ID_FMT, "0", plat->phy); port->phydev = phy_connect(dev, phy_id, &ixp4xx_adjust_link, 0, PHY_INTERFACE_MODE_MII); - if ((err = IS_ERR(port->phydev))) + if (IS_ERR(port->phydev)) { + err = PTR_ERR(port->phydev); goto err_free_mem; + } port->phydev->irq = PHY_POLL;
Right. Thanks. Acked-by: Krzysztof Halasa <khc@pm.waw.pl> -- Krzysztof Halasa