Thread (44 messages) 44 messages, 12 authors, 2011-01-04

Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.

From: Justin P. Mattock <hidden>
Date: 2011-01-01 14:53:13
Also in: linux-media, linux-scsi, linux-wireless, lkml

On 01/01/2011 01:09 AM, Dan Carpenter wrote:
On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote:
quoted
On 12/31/2010 10:48 PM, Finn Thain wrote:
quoted
quoted
-/*  BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable.					*/
+/*  BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled.					*/
I think, "other values disable" was what you meant?

Finn
quoted
  #define EEPROM_SW_AD_MASK			0x0300
  #define EEPROM_SW_AD_ENABLE			0x0100
no! I changed it to disabled to make it proper..
Finn is obviously right, but maybe a compromise would be:

Only the value EEPROM_SW_AD_ENABLE means "enable", other values mean
"disable".

regards,
dan carpenter
ahh.. I see what you your saying now.. alright let me send this out that 
way..

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help