Re: [PATCH]netdev: add driver for enc424j600 ethernet chip on SPI bus
From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2011-01-30 11:57:19
Balaji Venkatachalam [off-list ref] :
From: Balaji Venkatachalam <redacted> Updated patch [V1.29] for Microchip enc424j600 ethernet chip controlled via SPI. I tested it on my custom board with ARM9 (Freescale i.MX233) with Kernel 2.6.31.14.
[...]
4. mapped enc424j600_dump_regs to eth_ops get_regs
There is some kind of misunderstanding.
See include/linux/ethtool.h
[...]
struct ethtool_ops {
int (*get_settings)(struct net_device *, struct ethtool_cmd *);
int (*set_settings)(struct net_device *, struct ethtool_cmd *);
void (*get_drvinfo)(struct net_device *, struct ethtool_drvinfo *);
int (*get_regs_len)(struct net_device *);
void (*get_regs)(struct net_device *, struct ethtool_regs *, void *);
It should not even compile.
--
Ueimor