Re: [PATCH net-next-2.6] net_sched: sch_mqprio: dont leak kernel memory

From: Joe Perches <joe@perches.com>
Date: Wed, 26 Jan 2011 09:56:18 -0800

On Wed, 2011-01-26 at 18:49 +0100, Eric Dumazet wrote:

quoted

Le mercredi 26 janvier 2011 à 09:43 -0800, Joe Perches a écrit :

quoted

I think the best style to use memset so that any
possible struct padding is guaranteed to be zeroed.

We use the { 0 } style in net/sched,

That's nice, but it's the wrong style.
https://lkml.org/lkml/2010/12/15/63

quoted

and there is no padding in this
structure, I checked this point.

That may be true right now for this particular
structure, but that style is not future-proof.

It is future-proof if the data-structure is user-visible and therefore
will never change, as is the case here.