Re: [PATCH v2 1/3] can: at91_can: clean up usage of AT91_MB_RX_FIRST and AT91_MB_RX_NUM

On 01/22/2011 01:54 AM, David Miller wrote:

From: Marc Kleine-Budde <redacted>
Date: Mon, 17 Jan 2011 20:50:36 +0100

quoted

On 01/11/2011 02:21 PM, Marc Kleine-Budde wrote:

quoted

This patch cleans up the usage of two macros which specify the mailbox
usage. AT91_MB_RX_FIRST and AT91_MB_RX_NUM define the first and the
number of RX mailboxes. The current driver uses these variables in an
unclean way; assuming that AT91_MB_RX_FIRST is 0;

This patch cleans up the usage of these macros, no longer assuming
AT91_MB_RX_FIRST == 0.

Signed-off-by: Marc Kleine-Budde <redacted>

Any comments on this?

I would also seriously like to see these changes get some feedback,
they've been rotting in patchwork for more than a week.

V2 was OK and it got my "Acked-by" here:

http://marc.info/?l=linux-netdev&m=129534267002747&w=2

Wolfgang.