Re: [PATCH] e1000: add support for Marvell Alaska M88E1118R PHY

Hello Dirk, Jeff,

On Thursday 20 January 2011 19:49:19 Dirk Brandewie wrote:

On Wed, 2011-01-19 at 22:51 -0800, Jeff Kirsher wrote:

quoted

On Wed, Jan 19, 2011 at 01:09, Florian Fainelli [off-list ref] 

wrote:

quoted

quoted

From: Florian Fainelli <redacted>

This patch adds support for Marvell Alask M88E188R PHY chips. Support
for other M88* PHYs is already there, so there is nothing more to add
than its PHY id.

Signed-off-by: Florian Fainelli <redacted>
CC: Dirk Brandewie <redacted>
CC: Jeff Kirsher <redacted>
---

The patch itself looks fine.  I am concerned about validation.

Dirk - is there a chance that the ce4100 will use this PHY?  If so,
can you cover the validation?

Florian is working on a CE4100 based platform.  It looks like they used
a different PHY from the Flacon Falls reference platform. I can't
directly test this patch since I don't have their hardware.  I will be
testing .38-rc1 next week on falcon falls.

Indeed, we use this PHY on our hardware.

I think the best we can do without the hardware is to compare the data
sheet for the new PHY with the PHYs already supported and make sure they
are compatible.  If the datasheets match up for the features the driver
is using this seems pretty low risk IMHO.

As far as I could check, all M88E111* should behave the same for the setup 
done in e1000.
--
Florian