Thread (4 messages) 4 messages, 2 authors, 2011-01-20

[PATCH] netfilter: undefined reference to 'nf_conntrack_tstamp_*'

flat view
STALE5754d

From: John Fastabend <hidden>
Date: 2011-01-20 19:16:12
Also in: netfilter-devel
Subsystem: netfilter, networking [general], the rest · Maintainers: Pablo Neira Ayuso, Florian Westphal, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

net/built-in.o: In function `nf_conntrack_init_net':
net/netfilter/nf_conntrack_core.c:1521:
	undefined reference to `nf_conntrack_tstamp_init'
net/netfilter/nf_conntrack_core.c:1531:
	undefined reference to `nf_conntrack_tstamp_fini'

Add 'selects' notation to Kconfig to include NF_CONNTRACK_TIMESTAMP
this resolves all the config files I tested.

Signed-off-by: John Fastabend <redacted>
CC: Pablo Neira Ayuso <pablo@netfilter.org>
---

 net/netfilter/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index faf7412..2079911 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -27,6 +27,7 @@ config NETFILTER_NETLINK_LOG
 config NF_CONNTRACK
 	tristate "Netfilter connection tracking support"
 	default m if NETFILTER_ADVANCED=n
+	select NF_CONNTRACK_TIMESTAMP
 	help
 	  Connection tracking keeps a record of what packets have passed
 	  through your machine, in order to figure out how they are related
@@ -87,7 +88,7 @@ config NF_CONNTRACK_EVENTS
 
 config NF_CONNTRACK_TIMESTAMP
 	bool  'Connection tracking timestamping'
-	depends on NETFILTER_ADVANCED
+	default m if NETFILTER_ADVANCED
 	help
 	  This option enables support for connection tracking timestamping.
 	  This allows you to store the flow start-time and to obtain
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help