Re: inbound connection problems when "netlink: test for all flags of the NLM_F_DUMP composite" commit applied

On Tue, Jan 18, 2011 at 07:10:35PM +0100, Alessandro Suardi wrote:

On Tue, Jan 18, 2011 at 6:23 PM, Jarek Poplawski [off-list ref] wrote:

quoted

[PATCH] netlink: Fix possible NLM_F_DUMP misuse in genetlink

NLM_F_DUMP flags should be applied to GET requests only, eg. rtnetlink
tests message type to verify this. Since genetlink can't do the same
use "practical" test for ops->dumpit (assuming NEW request won't be
mixed with GET).

Signed-off-by: Jarek Poplawski <redacted>
Cc: Jan Engelhardt <redacted>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jamal Hadi Salim <redacted>
---
Not for stable before testing!

diff -Nurp a/net/netlink/genetlink.c b/net/netlink/genetlink.c

--- a/net/netlink/genetlink.c   2011-01-18 16:58:16.000000000 +0100
+++ b/net/netlink/genetlink.c   2011-01-18 17:08:43.000000000 +0100

@@ -519,15 +519,16 @@ static int genl_rcv_msg(struct sk_buff *

...

2.6.37-git18 + netlink revert + this patch
 - fixes Avahi
 - breaks acpid

Well, then fixing genetlink needs more than this and I withdraw this
patch. Anyway, netlink revert is IMHO needed to prevent the regression.

...

If more debugging/testing is needed, do ping me. Thanks,

Many thanks for such a fast response!
Jarek P.