Re: [PATCH v2 1/3] can: at91_can: clean up usage of AT91_MB_RX_FIRST and AT91_MB_RX_NUM

On 01/17/2011 08:50 PM, Marc Kleine-Budde wrote:

On 01/11/2011 02:21 PM, Marc Kleine-Budde wrote:

quoted

This patch cleans up the usage of two macros which specify the mailbox
usage. AT91_MB_RX_FIRST and AT91_MB_RX_NUM define the first and the
number of RX mailboxes. The current driver uses these variables in an
unclean way; assuming that AT91_MB_RX_FIRST is 0;

This patch cleans up the usage of these macros, no longer assuming
AT91_MB_RX_FIRST == 0.

Signed-off-by: Marc Kleine-Budde <redacted>

Any comments on this?

Looks fine too me. You can add my:

Acked-by: Wolfgang Grandegger <redacted>

Thanks,

Wolfgang.