Thread (3 messages) 3 messages, 3 authors, 2011-01-16

Re: [patch] caif: checking the wrong variable

From: David Miller <davem@davemloft.net>
Date: 2011-01-16 05:04:44
Also in: kernel-janitors

From: Sjur Brændeland <redacted>
Date: Sat, 15 Jan 2011 15:03:31 +0100
quoted
In the original code we check if (servl == NULL) twice.  The first time
should print the message that cfmuxl_remove_uplayer() failed and set
"ret" correctly, but instead it just returns success.  The second check
should be checking the value of "ret" instead of "servl".

Signed-off-by: Dan Carpenter <redacted>
Thank you for spotting and correcting this.
Looks good to me (reviewed only)

Acked-by: Sjur Braendeland <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help