Re: [PATCH 04/10] GRETH: added greth_compat_mode module parameter

David Miller wrote:

From: Daniel Hellstrom <redacted>
Date: Thu, 13 Jan 2011 09:25:29 +0100

 

quoted

The greth_compat_mode option can be used to set a GRETH GBit capable MAC
in operate as if the GRETH 10/100 device was found. The GRETH GBit supports
TCP/UDP checksum offloading, unaligned frame buffers, scatter gather etc.
Enabling this mode allows the developer to test the GRETH 10/100 device
without all features mentioned above on a GBit MAC capable of the above.

Signed-off-by: Daniel Hellstrom <redacted>
   

No special device specific module parameters please.

What if every single driver author added something like this and they
all named it something different or made it behave in slightly differing
ways?

What kind of user experience would that result in?

It would result in a sucky one, which is why we avoid adding all kinds
of hacky driver specific module options.

Find a generic way to provide this functionality.
 

I understand, it was not ment to be a user-experience, rather a developer debugging option. I will probably need an option like this in the future to avoid searching a very long time for very old hardware, I will try to find an other solution for it in the future.

I will remove the 3 GRETH patches and resubmit the others.

Thanks,
Daniel