Thread (3 messages) 3 messages, 3 authors, 2011-01-14

Re: [PATCH] net: remove dev_txq_stats_fold()

From: David Miller <hidden>
Date: 2011-01-14 05:45:04

Possibly related (same subject, not in this thread)

From: Eric Dumazet <redacted>
Date: Wed, 12 Jan 2011 23:13:14 +0100
[PATCH v2] net: remove dev_txq_stats_fold()

After recent changes, (percpu stats on vlan/tunnels...), we dont need
anymore per struct netdev_queue tx_bytes/tx_packets/tx_dropped counters.

Only remaining users are ixgbe, sch_teql, gianfar & macvlan :

1) ixgbe can be converted to use existing tx_ring counters.

2) macvlan incremented txq->tx_dropped, it can use the
dev->stats.tx_dropped counter.

3) sch_teql : almost revert ab35cd4b8f42 (Use net_device internal stats)
    Now we have ndo_get_stats64(), use it, even for "unsigned long"
fields (No need to bring back a struct net_device_stats)

4) gianfar adds a stats structure per tx queue to hold
tx_bytes/tx_packets

This removes a lockdep warning (and possible lockup) in rndis gadget,
calling dev_get_stats() from hard IRQ context.

Ref: http://www.spinics.net/lists/netdev/msg149202.html

Reported-by: Neil Jones <redacted>
Signed-off-by: Eric Dumazet <redacted>
CC: Jarek Poplawski <redacted>
CC: Alexander Duyck <redacted>
CC: Jeff Kirsher <redacted>
CC: Sandeep Gopalpet <redacted>
CC: Michal Nazarewicz <redacted>
Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help