Thread (7 messages) 7 messages, 4 authors, 2011-01-13

Re: [PATCH] ipv4: devconf: start IPV4_DEVCONF_* from 0

flat view

From: David Miller <davem@davemloft.net>
Date: 2011-01-13 20:28:24

From: Lucian Adrian Grijincu <redacted>
Date: Thu, 13 Jan 2011 14:23:41 +0200
On Thu, Jan 13, 2011 at 12:02 PM, Thomas Graf [off-list ref] wrote:
quoted
On Thu, Jan 13, 2011 at 09:50:14AM +0200, Lucian Adrian Grijincu wrote:
quoted
Yes it works, but there does not seem to be a good reason why to
complicate things like this (again the sentinel nature of zero is not
used in any place here).
I have no objects to changing this at all but we don't gain much either.

Should I post a new patch in which IFLA_INET_CONF cfgid values start
from 0 also or must the ABI for libnl be kept as-is (counting from 1)?
I think the conclusion is that we won't apply your change, sorry.

There is almost zero upside, and one known downside in that we have
to deal with this user visible breakage somehow.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help