Re: [PATCH] tcp: remove duplicate th = tcp_hdr(skb)
flat view
From: Jesse Gross <hidden>
Date: 2011-01-13 15:54:16
On Thu, Jan 13, 2011 at 10:41 AM, Christoph Paasch [off-list ref] wrote:
quoted hunk ↗ jump to hunk
th is already set some lines before to be th = tcp_hdr(skb). Signed-off-by: Christoph Paasch <redacted> --- net/ipv4/tcp_ipv4.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 856f684..7fe29c6 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c@@ -1644,7 +1644,6 @@ int tcp_v4_rcv(struct sk_buff *skb)if (!skb_csum_unnecessary(skb) && tcp_v4_checksum_init(skb)) goto bad_packet; - th = tcp_hdr(skb);
It needs to be reloaded because pskb_may_pull() may reallocate the buffer.