Thread (5 messages) 5 messages, 2 authors, 2011-01-12

Re: [PATCH v2 2/2] netlink: support setting devgroup parameters

flat view

From: jamal <hidden>
Date: 2011-01-12 15:44:05

On Tue, 2011-01-11 at 18:35 +0200, Vlad Dogaru wrote:
If a rtnetlink request specifies a negative or zero ifindex and has no
interface name attribute, but has a group attribute, then the chenges
are made to all the interfaces belonging to the specified group.

Signed-off-by: Vlad Dogaru <redacted>
Looks good. Please just do some basic tests like setting a few
interfaces to the same group, changing their MTU and setting admin
up then down. If it works add my ACKed-by on both patches.
The only thing that will still generate a lot of noise is the netlink
events that will be generated afterwards for each change on a netdev in
a group i.e a single netlink message..

Maybe we could batch those in a future patch

cheers,
jamal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help