Re: [PATCH net-next-2.6 v2 1/2] can: add driver for Softing card

quoted

quoted

+	if (type != 0xffff) {
+		dev_alert(&card->pdev->dev, "firware starts with type 0x%04x\n",

Typo?

??

I think he means "fir[m]ware"

quoted

quoted

+
+int softing_default_output(struct net_device *netdev)
+{
+	struct softing_priv *priv = netdev_priv(netdev);
+	struct softing *card = priv->card;
+
+	switch (priv->chip) {
+	case 1000:
+		if (card->pdat->generation < 2)
+			return 0xfb;
+		return 0xfa;

A ternary operator might look nicer here because of just a single return.

Best wishes,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |