Thread (5 messages) 5 messages, 4 authors, 2011-01-05

Re: [PATCH] net_sched: pfifo_head_drop problem

flat view

From: Hagen Paul Pfeifer <hidden>
Date: 2011-01-05 20:52:19

* Eric Dumazet | 2011-01-05 21:35:02 [+0100]:
My mid term suggestion would be to change things so that
sch->bstats.bytes and sch->bstats.packets are incremented in dequeue()
only, not at enqueue() time. We also could add drop_bytes/drop_packets
and provide estimations of drop rates.

It would be more sensible anyway for very low speeds, and big bursts.
Right now, if we drop packets, they still are accounted in byte/packets
abolute counters and rate estimators.

Before this mid term change, this patch makes pfifo_head_drop behavior
similar to other qdiscs in case of drops :
Dont decrement sch->bstats.bytes and sch->bstats.packets
Thanks Stephen and Erik for spotting this bug!
Signed-off-by: Eric Dumazet <redacted>
Acked-by: Hagen Paul Pfeifer <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help