Thread (27 messages) 27 messages, 3 authors, 2011-01-12

Re: [RFC] sched: CHOKe packet scheduler

flat view

From: Stephen Hemminger <hidden>
Date: 2011-01-05 17:17:20

On Wed, 05 Jan 2011 07:19:35 +0100
Eric Dumazet [off-list ref] wrote:
Le mardi 04 janvier 2011 à 16:29 -0800, Stephen Hemminger a écrit :
quoted
+static struct sk_buff *skb_peek_random(struct sk_buff_head *list)
+{
+	struct sk_buff *skb = list->next;
+	unsigned int idx = net_random() % list->qlen;
+
+	while (skb && idx-- > 0)
+		skb = skb->next;
+
+	return skb;
+}
You could avoid the divide op :

unsigned int idx = reciprocal_divide(random32(), list->qlen);
How would this work, it is a mod not a divide??

-- 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help