Re: [PATCH v2 net-next-2.6] ifb: add performance flags
From: Jarek Poplawski <hidden>
Date: 2011-01-03 19:37:13
On Sun, Jan 02, 2011 at 09:24:36PM +0100, Eric Dumazet wrote:
Le mercredi 29 décembre 2010 ?? 00:07 +0100, Jarek Poplawski a écrit :quoted
Ingress is before vlans handler so these features and the NETIF_F_HW_VLAN_TX flag seem useful for ifb considering dev_hard_start_xmit() checks.OK, here is v2 of the patch then, thanks everybody. [PATCH v2 net-next-2.6] ifb: add performance flags IFB can use the full set of features flags (NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO | NETIF_F_NO_CSUM | NETIF_F_HIGHDMA) to avoid unnecessary split of some packets (GRO for example) Changli suggested to also set vlan_features,
He also suggested more GSO flags of which especially NETIF_F_TSO6 seems interesting (wrt GRO)? Jarek P.
quoted hunk ↗ jump to hunk
Jarek suggested to add NETIF_F_HW_VLAN_TX as well. Signed-off-by: Eric Dumazet <redacted> Cc: Changli Gao <redacted> Cc: Jarek Poplawski <redacted> Cc: Pawel Staszewski <redacted> --- drivers/net/ifb.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c index 124dac4..66ca7bf 100644 --- a/drivers/net/ifb.c +++ b/drivers/net/ifb.c@@ -126,6 +126,9 @@ static const struct net_device_ops ifb_netdev_ops = { .ndo_validate_addr = eth_validate_addr, }; +#define IFB_FEATURES (NETIF_F_NO_CSUM | NETIF_F_SG | NETIF_F_FRAGLIST | \ + NETIF_F_HIGHDMA | NETIF_F_TSO | NETIF_F_HW_VLAN_TX) + static void ifb_setup(struct net_device *dev) { /* Initialize the device structure. */@@ -136,6 +139,9 @@ static void ifb_setup(struct net_device *dev) ether_setup(dev); dev->tx_queue_len = TX_Q_LIMIT; + dev->features |= IFB_FEATURES; + dev->vlan_features |= IFB_FEATURES; + dev->flags |= IFF_NOARP; dev->flags &= ~IFF_MULTICAST; dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;